Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointers when time.Duration could be nil #2504

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

Fixes #2487

There are some cases when a returned time.Duration could be nil for origin request config. I wasn't able to get the nil error 100% of the time but this should handle all cases.

@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from jacobbednarz as a code owner June 6, 2023 06:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

cc @obezuk

@szandala

This comment was marked as spam.

@Cyb3r-Jak3
Copy link
Contributor Author

This will need to be updated with cloudflare/cloudflare-go#1303

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTunnelConfig_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTunnelConfig_Full
--- PASS: TestAccCloudflareTunnelConfig_Full (9.42s)
=== RUN   TestAccCloudflareTunnelConfig_Short
--- PASS: TestAccCloudflareTunnelConfig_Short (8.09s)
=== RUN   TestAccCloudflareTunnelConfig_NilPointer
--- PASS: TestAccCloudflareTunnelConfig_NilPointer (7.88s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	26.383s

@github-actions
Copy link
Contributor

This functionality has been released in v4.9.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV in cloudflare_tunnel_config: nil pointer dereference
3 participants