Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_notification_policy_webhooks: url triggers recreation #2302

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

jacobbednarz
Copy link
Member

Updates url to force a new resource instead of updating in place.

Closes #2266

…eation

Updates `url` to force a new resource instead of updating in place.

Closes #2266
@jacobbednarz
Copy link
Member Author

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareNotificationPolicy_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareNotificationPolicy_Basic
--- PASS: TestAccCloudflareNotificationPolicy_Basic (22.98s)
=== RUN   TestAccCloudflareNotificationPolicy_WithFiltersAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithFiltersAttribute (23.21s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	47.129s

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 7faae06 into master Mar 20, 2023
@jacobbednarz jacobbednarz deleted the notification-webhooks-update-for-new-url branch March 20, 2023 02:14
@github-actions github-actions bot added this to the v4.2.0 milestone Mar 20, 2023
github-actions bot pushed a commit that referenced this pull request Mar 20, 2023
rwhelan pushed a commit to rwhelan/terraform-provider-cloudflare that referenced this pull request Mar 20, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource cloudflare_notification_policy_webhooks should be replaced when url is updated
1 participant