Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmark to AccessApplication type #1363

Closed
wants to merge 1 commit into from

Conversation

ouranos
Copy link
Contributor

@ouranos ouranos commented Dec 29, 2021

#1343 only added the documentation without updating the field validation.
Fixes #1358.

It is supported by the SDK but not documented.

When trying to provision some bookmark app with the provider, I get:

Error: error updating Access Application for account "xxx": HTTP status 400: access.api.error.invalid_create_app_request (12090)

If reproducing the request with curl, I get:

{
    "result": null,
    "success": false,
    "errors": [
        {
            "code": 12090,
            "message": "access.api.error.invalid_create_app_request"
        }
    ],
    "messages": [
        {
            "message": "bookmark application must be updated at the /access/bookmark path"
        }
    ]
}

@ouranos
Copy link
Contributor Author

ouranos commented Dec 29, 2021

As discussed in #1358, this needs more work on the SDK, hence leaving it in draft for now.

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_application doesn't recognize bookmark type
1 participant