Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary bind on keydown handler #10

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Remove unnecessary bind on keydown handler #10

merged 1 commit into from
Jan 14, 2016

Conversation

ntharim
Copy link
Contributor

@ntharim ntharim commented Jan 14, 2016

bind creates a new function so the keydown handler is not actually removed on componentWillUnmount. And since handleDocumentKeydown is an arrow function bind is not actually necessary.

@jamiebuilds
Copy link
Contributor

Oh wow, thank you

jamiebuilds added a commit that referenced this pull request Jan 14, 2016
@jamiebuilds
Merge pull request #10 from nthtran/patch-1
a1d6b5d 
Remove unnecessary `bind` on `keydown` handler
@jamiebuilds jamiebuilds merged commit a1d6b5d into cloudflare:master Jan 14, 2016
@jamiebuilds
Copy link
Contributor

Published as v3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntharim @jamiebuilds