stream: use VecDeque to store SendBuf data #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to be better names.
This changes the internal storage of SendBuf to a VecDeque, but it doesn't change the underlying logic. In the future this will allow us to change how SendBuf data is emitted to avoid the allocation and additional copy we currently perform. In most cases insertions to the SendBuf happen at the end of the buffer, however, due to the fact that buffers need to be stored in order, in case of retransmissions they might happen at any index in the vector. While at it, the SendBuf::push_slice() method is also renamed to SendBuf::write() to be consistent with RecvBuf.
LPardue
reviewed
Nov 3, 2020
Comment on lines
+1000
to
+1005
| for i in 0..self.data.len() { | ||
| if buf.off < self.data[i].off { | ||
| insert_at = Some(i); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe a chance to improve this further once binary_search lands? rust-lang/rust#78021
There was a problem hiding this comment.
The implementation looks pretty simple, so we can probably do it without waiting for that PR. Though note that after the next set of changes (once I get them to work) we won't need the slow path anymore as we will always appending to the end, so might end up being wasted work.
LPardue
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the internal storage of SendBuf to a VecDeque, but it
doesn't change the underlying logic. In the future this will allow us to
change how SendBuf data is emitted to avoid the allocation and
additional copy we currently perform.
In most cases insertions to the SendBuf happen at the end of the buffer,
however, due to the fact that buffers need to be stored in order, in
case of retransmissions they might happen at any index in the vector.
While at it, the SendBuf::push_slice() method is also renamed to
SendBuf::write() to be consistent with RecvBuf.