-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump undici version and minimum node version #333
Conversation
To target security vulnerabilities in undici, we update to the latest version. From undici v5.7.0, we require a node >=16.8.0 - here we update the minimum to 16.13.0 (the first Node 16 LTS release)
We should pin the version of undici
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as @mrbbot is good with these changes, I think it is good to go.
Just worth noting that this will require some people to bump their version of node - I assume we have some precedent for a release like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! 🙂 Added a couple tiny commits to fix tests, but otherwise... ✅
Would you be ok using 16.8.0 as the minimum version instead? Makes the breaking change radius a little smaller. |
The thinking here was what if |
That's fair. Let's land this? |
wait it was landed already ha |
...and released in |
To target security vulnerabilities in undici, we update to the latest version.
From undici v5.7.0, we require a node >=16.8.0 - here we update the minimum to 16.13.0 (the first Node 16 LTS release)