Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): api update #2221

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .stats.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
configured_endpoints: 1436
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-c5682a28c312411d32f5a8447e4c50880eabf7d71415128758e7924dc434c4da.yml
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-83d644e928810036deb1b08729305b0adf41c6e1bfbb58e6427c999fdaa85eca.yml
2 changes: 1 addition & 1 deletion api.md
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,7 @@ from cloudflare.types.dnssec import DNSSEC, DNSSECDeleteResponse

Methods:

- <code title="delete /zones/{zone_id}/dnssec">client.dnssec.<a href="./src/cloudflare/resources/dnssec.py">delete</a>(\*, zone_id) -> <a href="./src/cloudflare/types/dnssec/dnssec_delete_response.py">Optional[DNSSECDeleteResponse]</a></code>
- <code title="delete /zones/{zone_id}/dnssec">client.dnssec.<a href="./src/cloudflare/resources/dnssec.py">delete</a>(\*, zone_id) -> <a href="./src/cloudflare/types/dnssec/dnssec_delete_response.py">str</a></code>
- <code title="patch /zones/{zone_id}/dnssec">client.dnssec.<a href="./src/cloudflare/resources/dnssec.py">edit</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/dnssec/dnssec_edit_params.py">params</a>) -> <a href="./src/cloudflare/types/dnssec/dnssec.py">Optional[DNSSEC]</a></code>
- <code title="get /zones/{zone_id}/dnssec">client.dnssec.<a href="./src/cloudflare/resources/dnssec.py">get</a>(\*, zone_id) -> <a href="./src/cloudflare/types/dnssec/dnssec.py">Optional[DNSSEC]</a></code>

Expand Down
52 changes: 21 additions & 31 deletions src/cloudflare/resources/dnssec.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from __future__ import annotations

from typing import Any, Type, Optional, cast
from typing import Type, Optional, cast
from typing_extensions import Literal

import httpx
Expand Down Expand Up @@ -59,7 +59,7 @@ def delete(
extra_query: Query | None = None,
extra_body: Body | None = None,
timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
) -> Optional[DNSSECDeleteResponse]:
) -> str:
"""
Delete DNSSEC.

Expand All @@ -76,21 +76,16 @@ def delete(
"""
if not zone_id:
raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
return cast(
Optional[DNSSECDeleteResponse],
self._delete(
f"/zones/{zone_id}/dnssec",
options=make_request_options(
extra_headers=extra_headers,
extra_query=extra_query,
extra_body=extra_body,
timeout=timeout,
post_parser=ResultWrapper[Optional[DNSSECDeleteResponse]]._unwrapper,
),
cast_to=cast(
Any, ResultWrapper[DNSSECDeleteResponse]
), # Union types cannot be passed in as arguments in the type system
return self._delete(
f"/zones/{zone_id}/dnssec",
options=make_request_options(
extra_headers=extra_headers,
extra_query=extra_query,
extra_body=extra_body,
timeout=timeout,
post_parser=ResultWrapper[Optional[DNSSECDeleteResponse]]._unwrapper,
),
cast_to=cast(Type[str], ResultWrapper[str]),
)

def edit(
Expand Down Expand Up @@ -232,7 +227,7 @@ async def delete(
extra_query: Query | None = None,
extra_body: Body | None = None,
timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
) -> Optional[DNSSECDeleteResponse]:
) -> str:
"""
Delete DNSSEC.

Expand All @@ -249,21 +244,16 @@ async def delete(
"""
if not zone_id:
raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
return cast(
Optional[DNSSECDeleteResponse],
await self._delete(
f"/zones/{zone_id}/dnssec",
options=make_request_options(
extra_headers=extra_headers,
extra_query=extra_query,
extra_body=extra_body,
timeout=timeout,
post_parser=ResultWrapper[Optional[DNSSECDeleteResponse]]._unwrapper,
),
cast_to=cast(
Any, ResultWrapper[DNSSECDeleteResponse]
), # Union types cannot be passed in as arguments in the type system
return await self._delete(
f"/zones/{zone_id}/dnssec",
options=make_request_options(
extra_headers=extra_headers,
extra_query=extra_query,
extra_body=extra_body,
timeout=timeout,
post_parser=ResultWrapper[Optional[DNSSECDeleteResponse]]._unwrapper,
),
cast_to=cast(Type[str], ResultWrapper[str]),
)

async def edit(
Expand Down
3 changes: 1 addition & 2 deletions src/cloudflare/types/dnssec/dnssec_delete_response.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.

from typing import Union
from typing_extensions import TypeAlias

__all__ = ["DNSSECDeleteResponse"]

DNSSECDeleteResponse: TypeAlias = Union[str, object]
DNSSECDeleteResponse: TypeAlias = str
14 changes: 7 additions & 7 deletions tests/api_resources/test_dnssec.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from cloudflare import Cloudflare, AsyncCloudflare
from tests.utils import assert_matches_type
from cloudflare.types.dnssec import DNSSEC, DNSSECDeleteResponse
from cloudflare.types.dnssec import DNSSEC

base_url = os.environ.get("TEST_API_BASE_URL", "http://127.0.0.1:4010")

Expand All @@ -22,7 +22,7 @@ def test_method_delete(self, client: Cloudflare) -> None:
dnssec = client.dnssec.delete(
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
)
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

@parametrize
def test_raw_response_delete(self, client: Cloudflare) -> None:
Expand All @@ -33,7 +33,7 @@ def test_raw_response_delete(self, client: Cloudflare) -> None:
assert response.is_closed is True
assert response.http_request.headers.get("X-Stainless-Lang") == "python"
dnssec = response.parse()
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

@parametrize
def test_streaming_response_delete(self, client: Cloudflare) -> None:
Expand All @@ -44,7 +44,7 @@ def test_streaming_response_delete(self, client: Cloudflare) -> None:
assert response.http_request.headers.get("X-Stainless-Lang") == "python"

dnssec = response.parse()
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

assert cast(Any, response.is_closed) is True

Expand Down Expand Up @@ -150,7 +150,7 @@ async def test_method_delete(self, async_client: AsyncCloudflare) -> None:
dnssec = await async_client.dnssec.delete(
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
)
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

@parametrize
async def test_raw_response_delete(self, async_client: AsyncCloudflare) -> None:
Expand All @@ -161,7 +161,7 @@ async def test_raw_response_delete(self, async_client: AsyncCloudflare) -> None:
assert response.is_closed is True
assert response.http_request.headers.get("X-Stainless-Lang") == "python"
dnssec = await response.parse()
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

@parametrize
async def test_streaming_response_delete(self, async_client: AsyncCloudflare) -> None:
Expand All @@ -172,7 +172,7 @@ async def test_streaming_response_delete(self, async_client: AsyncCloudflare) ->
assert response.http_request.headers.get("X-Stainless-Lang") == "python"

dnssec = await response.parse()
assert_matches_type(Optional[DNSSECDeleteResponse], dnssec, path=["response"])
assert_matches_type(str, dnssec, path=["response"])

assert cast(Any, response.is_closed) is True

Expand Down