go.mod: fix invalid pseudo versions #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising the issue. I'm not completely sure what 1.13 proxy issue is, but removed unused golang.org/x/lint reference anyways. If there is still anything to fix, please let me know. |
|
@patryk there's still a problem with |
|
For more context, I linked the Go issue above, TL;DR is that your go.mod file has what seems to be manually written pseudo semvers that Go 1.13 no longer accepts. Your pseudo version timestamp must match the commit timestamp |
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.13 seems to invalidate
golang.org/x/lint v0.0.0-20190511005446-959b441ac422and furthermore, this repo seems to not need it since runninggo mod tidyremoves it completely. Out of curiosity, was this pseudo version manually written?For more info see, golang/go#33513