Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage account members endpoints #196

Merged
merged 9 commits into from
Jul 26, 2018
Merged

Manage account members endpoints #196

merged 9 commits into from
Jul 26, 2018

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Jun 27, 2018

Following on from #195, this introduces the account member endpoints
which allow you to add, remove and manage users within an account (aka
v2 of user management in organisations).

@jacobbednarz
Copy link
Member Author

The CI failures are due to go fmt differences between 1.{7,10} and 1.11beta1 (which we test for using LATEST=true in the CI pipeline.

I've raised golang/go#26098 to confirm whether this is intentional or a regression.

@jacobbednarz
Copy link
Member Author

Turns out this is intentional (see golang/go@542ea5a). I'll have a bit of a think about what we could do with this going forward to keep go fmt but also meet the formatting guidelines on both versions.

@jacobbednarz
Copy link
Member Author

CI will be fixed once #201 lands.

@jacobbednarz
Copy link
Member Author

I've removed the duplication of AccountRoles in db2b323 which means that #199 should be merged first and then rekick off the CI for this branch to make it green.

Creates the functionality to be able to query all members of an account.

See https://api.cloudflare.com/#accounts-list-accounts
Adds the ability to create a new account member using the API.

See https://api.cloudflare.com/#account-members-add-member
Allows you to update existing users using the library.

See https://api.cloudflare.com/#account-members-update-member
If you can create 'em, you gotta be able to delete 'em.

See https://api.cloudflare.com/#account-members-remove-member
`AccountMemberRole` is actually the same thing as `AccountRole` however
due to running across multiple branches, we needed this in both places.

This removes the duplication and leaves `AccountRole`.
@jacobbednarz
Copy link
Member Author

@patryk we're all good to roll with this one now! 🙇

@patryk patryk merged commit 5288c3c into cloudflare:master Jul 26, 2018
@patryk
Copy link

patryk commented Jul 26, 2018

Love it, keep up the great work. 👊

@jacobbednarz jacobbednarz deleted the add-account-members branch July 26, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants