Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Page Shield API #1054

Closed
wants to merge 4 commits into from

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds support for the Page Shield API

https://api.cloudflare.com/#page-shield-properties

Has your change been tested?

Created units tests and all pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

}
uri := fmt.Sprintf("/zones/%s/page_shield", rc.Identifier)

_, err := api.makeRequestContext(ctx, http.MethodGet, uri, nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've got a feeling, the docs are broken for this as we don't have a body. i'll ping the team.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1054 (22f486a) into master (e39278e) will increase coverage by 0.16%.
The diff coverage is 81.53%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   49.94%   50.11%   +0.16%     
==========================================
  Files         115      116       +1     
  Lines       10991    11052      +61     
==========================================
+ Hits         5490     5539      +49     
- Misses       4338     4346       +8     
- Partials     1163     1167       +4     
Impacted Files Coverage Δ
teams_accounts.go 53.84% <ø> (ø)
page_shield.go 80.32% <80.32%> (ø)
r2_bucket.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants