Added docs for cache: no-store #17926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned GregBrimble, irvinebroque, mikenomitch, ToriLindsay, WalshyDev and jasnell
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 files reviewed, 1 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
Deploying cloudflare-docs with
|
| Latest commit: |
9559fcc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a039c28.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://adityaatultewari-cache-no-st.cloudflare-docs-7ou.pages.dev |
mhart
reviewed
Nov 2, 2024
irvinebroque
requested review from
mikenomitch,
GregBrimble,
a team,
jasnell,
WalshyDev and
ToriLindsay
as code owners
mikenomitch
reviewed
Nov 7, 2024
|
|
||
| For a cross-zone request this simply specifies the headers `Pragma: no-cache` and `Cache-Control: no-cache` to the origin. | ||
|
|
||
| For grey-cloud subrequests this bypasses the Cloudflare's cache. |
There was a problem hiding this comment.
We sometimes use grey cloud in external docs, but for the most part I think we shouldn't. We know what it means internally, but average new user won't.
There was a problem hiding this comment.
do we want to do the same with cross-zone?
mikenomitch
reviewed
Nov 7, 2024
mikenomitch
reviewed
Nov 7, 2024
| When `no-store` is supplied the cache is bypassed both on the way to the origin and on the way back. | ||
| For cross-zone requests this simply forwards the `Pragma: no-cache` and `Cache-Control: no-cache` headers to the origin. | ||
| This is because the cache is on the origin side for cross-zone requests. | ||
| For grey-cloud requests this bypasses the use of Cloudflare's caches. |
There was a problem hiding this comment.
Noting the other "grey-cloud" use (see above)
There was a problem hiding this comment.
Same question here about cross-zone.
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
from
b8d038f to
f151c78
Compare
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
3 times, most recently
from
b9d12ae to
f323be7
Compare
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
6 times, most recently
from
62a4ca4 to
f464845
Compare
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
from
f464845 to
6b48f86
Compare
mhart
reviewed
Nov 11, 2024
mikenomitch
requested changes
Nov 12, 2024
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
9 times, most recently
from
2cfc3a4 to
0f090f6
Compare
tewaro
force-pushed
the
AdityaAtulTewari/cache-no-store-update
branch
from
0f090f6 to
9559fcc
Compare
mikenomitch
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Documentation for adding
cache: no-store.Documentation checklist