Promote Node.js compat #16918
Promote Node.js compat #16918
Conversation
ToriLindsay
requested review from
GregBrimble,
WalshyDev,
kodster28,
aninibread and
a team
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
24b0640
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://788e1972.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tori-pcx13350-promote-nodejs.cloudflare-docs-7ou.pages.dev |
| @@ -45,7 +45,7 @@ Refer to [Routing](/pages/functions/routing/) for more information on route cust | |||
|
|
|||
| ### Runtime features | |||
|
|
|||
| Workers runtime features, including compatibility with a subset of Node.js APIs and setting a [compatibility date or compatibility flag](/workers/configuration/compatibility-dates/) are configurable on Pages Functions. | |||
| [Workers runtime features](workers/runtime-apis/#_top) are configurable on Pages Functions, including [compatibility with a subset of Node.js APIs](/workers/runtime-apis/nodejs). | |||
|
|
|||
| Set these configurations by passing an argument to your [Wrangler](/workers/wrangler/commands/#dev-1) command or by setting them in the dashboard. To set Pages compatibility flags in the Cloudflare dashboard: | |||
There was a problem hiding this comment.
Might need to keep the info on the compat flags though.... I suppose I don't know the relative importance of nodejs compat vs compat dates in the functions onboarding experience.
Might be a question for @dario-piotrowicz?
There was a problem hiding this comment.
When I spoke to Sam, these were the pages he recommended, but if anyone who is reviewing has additional thoughts on where promoting would be helpful, feel free to make suggestions.
I'd note that it's also already mentioned in the intro of https://developers.cloudflare.com/workers/runtime-apis/
There was a problem hiding this comment.
Compat flags still necessary here, and I don't see them mentioned in the intro of https://developers.cloudflare.com/workers/runtime-apis/ ?
There was a problem hiding this comment.
@irvinebroque Sorry about that. I originally removed it because the sentence didn't link to the Node compat page (which was the origin of this request) and I didn't realize it needed both. I added the link to the compat date/flag page back and I added the compat date/flag link to the mention at https://developers.cloudflare.com/workers/runtime-apis/ as well.
Co-authored-by: Kody Jackson <[email protected]>
|
Update: Following up with assignees on approving this one via Chat. |
|
@irvinebroque I updated this PR per your comment. Please review and approve when you have a chance. Thanks! |
* Add/Edit two lines to promote Node.js compat * Apply suggestions from code review Co-authored-by: Kody Jackson <[email protected]> * Updated all with compat date and flag --------- Co-authored-by: Kody Jackson <[email protected]>
* Add/Edit two lines to promote Node.js compat * Apply suggestions from code review Co-authored-by: Kody Jackson <[email protected]> * Updated all with compat date and flag --------- Co-authored-by: Kody Jackson <[email protected]>
Summary
I'm still learning about these products so please feel free to edit what I wrote if it doesn't make sense or isn't addressing the request.