Align internal SHAKE buffer when using it as []uint64 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go runtime assumes that a pointer to a type is aligned on the size of that type. We cast a [N]byte to []uint64, which breaks this assumption. Thus allocate the original [N]byte as a [N/8]uint64 instead. Fixes cloudflare#89 Cf. the same issue and patch in upstream: patch https://go-review.googlesource.com/c/crypto/+/203837/ issue golang/go#35173
armfazh
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go runtime assumes that a pointer to a type is aligned on the size
of that type. We cast a [N]byte to []uint64, which breaks this
assumption. Thus allocate the original [N]byte as a [N/8]uint64 instead.
Fixes #89
Cf. the same issue and patch in upstream:
patch https://go-review.googlesource.com/c/crypto/+/203837/
issue golang/go#35173