Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go 1.16 version. #215

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Add go 1.16 version. #215

merged 5 commits into from
Mar 3, 2021

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 16, 2021

Adds go1.16 version for testing.

@armfazh armfazh self-assigned this Feb 16, 2021
@armfazh
Copy link
Contributor Author

armfazh commented Feb 16, 2021

todo; To investigate clobbered registers in dillithium assembler code.

@bwesterb
Copy link
Member

It's an issue with avo: mmcloughlin/avo#156

@claucece
Copy link
Contributor

claucece commented Mar 2, 2021

I also have it happening in kyber:

pke/kyber/internal/common/amd64.s:1448:1: frame pointer is clobbered before saving

The HasSha3 does not exist anymore (in simd/keccakf1600/f1600x.go) in arm64 on go.16 as well:

// IsEnabledX2 returns true if the architecture supports a two-way SIMD
// implementation provided in this package.
func IsEnabledX2() bool { return cpu.ARM64.HasSHA3 }

We are using the x/sys one, but it might be bumped down there too: golang/go@6b66b59#diff-52c997d62192731381cdec487ea0eb77390c9ea5941e4d3ac4c9109c272417f6

@bwesterb bwesterb

@claucece
Copy link
Contributor

claucece commented Mar 2, 2021

@armfazh armfazh requested review from cjpatton and claucece March 3, 2021 00:06
@armfazh
Copy link
Contributor Author

armfazh commented Mar 3, 2021

@cjpatton @claucece please take a look.

@claucece
Copy link
Contributor

claucece commented Mar 3, 2021

LGTM ;) Thanks!

Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simd/keccakf1600/f1600x.go Outdated Show resolved Hide resolved
Co-authored-by: Christopher Patton <[email protected]>
@armfazh armfazh merged commit 8bfb091 into master Mar 3, 2021
@armfazh armfazh deleted the armfazh/go1.16 branch March 24, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants