Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in eddilithium3 package: References to "eddilithium4" #502

Closed
y12studio opened this issue Jul 4, 2024 · 1 comment · Fixed by #503
Closed

Typo in eddilithium3 package: References to "eddilithium4" #502

y12studio opened this issue Jul 4, 2024 · 1 comment · Fixed by #503

Comments

@y12studio
Copy link

There are multiple instances where the eddilithium3 package incorrectly references "eddilithium4" in error messages. This appears to be a typo that needs to be corrected.

$ curl -s https://raw.githubusercontent.com/cloudflare/circl/v1.3.9/sign/eddilithium3/eddilithium.go | grep -A2 -B2 eddilithium4

func (pk *PublicKey) UnmarshalBinary(data []byte) error {
	if len(data) != PublicKeySize {
		return errors.New("packed public key must be of eddilithium4.PublicKeySize bytes")
	}
	var buf [PublicKeySize]byte
--
func (sk *PrivateKey) UnmarshalBinary(data []byte) error {
	if len(data) != PrivateKeySize {
		return errors.New("packed private key must be of eddilithium4.PrivateKeySize bytes")
	}
	var buf [PrivateKeySize]byte
--

	if opts.HashFunc() != crypto.Hash(0) {
		return nil, errors.New("eddilithium4: cannot sign hashed message")
	}
bwesterb added a commit that referenced this issue Jul 5, 2024
@bwesterb
Copy link
Member

bwesterb commented Jul 5, 2024

Thanks.

armfazh pushed a commit that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants