Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boring to 2018 edition #51

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Update boring to 2018 edition #51

merged 2 commits into from
Aug 13, 2021

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Aug 12, 2021

I recommend reviewing this by running cargo fix --edition locally and making sure the output is the same; I know the diff is giant.

This found a bug in cargo: rust-lang/cargo#9782.

@jyn514 jyn514 requested a review from cjmakes August 12, 2021 16:34
cjmakes
cjmakes approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@cjmakes cjmakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches what my machine says 😄

@jyn514 jyn514 merged commit c037a43 into master Aug 13, 2021
@jyn514 jyn514 deleted the jnelson/2018 branch August 13, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjmakes cjmakes cjmakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @cjmakes