Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add process plugin for browser compatibility #526

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

lholmquist
Copy link
Contributor

@lholmquist lholmquist commented Feb 10, 2023

Adds process plugin for webpack 5 and greater.

fixes #525

see browserify/node-util#57 (comment) for the fix

…aking becuase of process not being found.

fixes cloudevents#525

Signed-off-by: Lucas Holmquist <[email protected]>
@lholmquist lholmquist requested a review from lance February 10, 2023 19:08
@lance lance changed the title fix: This fixes bug #525 where the browser version was breaking becua… fix: add process plugin for browser compatibility Feb 12, 2023
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lholmquist!

@lance lance merged commit e5ee836 into cloudevents:main Feb 12, 2023
@lholmquist lholmquist deleted the webpack_5_breaking_process branch February 13, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work in browsers as of 5.3.1
2 participants