Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWX-18731 CDP DW create and delete hive virtual warehouse #135

Merged
merged 4 commits into from
Jul 8, 2024
Merged

DWX-18731 CDP DW create and delete hive virtual warehouse #135

merged 4 commits into from
Jul 8, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Jun 7, 2024

First version of a hive virtual warehouse creation and deletion.

@tevesz tevesz requested a review from vcsomor June 7, 2024 01:38
vcsomor
vcsomor reviewed Jun 7, 2024
View reviewed changes
provider/provider_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw.go Show resolved Hide resolved
resources/dw/schema_hive_vw.go Show resolved Hide resolved
@tevesz tevesz marked this pull request as ready for review June 20, 2024 23:37
@tevesz tevesz requested a review from a team as a code owner June 20, 2024 23:37
@tevesz tevesz changed the title CDP CDW PoC create and delete hive virtual warehouse CDP CDW create and delete hive virtual warehouse Jun 21, 2024
vcsomor
vcsomor previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ AFAIK there is only one thing remaining for the acceptance tests, which is waiting for the Hive resource to be created.

Conditional approval.

.mockery.yaml Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw.go Show resolved Hide resolved
resources/dw/resource_hive_vw_acc_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_acc_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_acc_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_test.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_test.go Outdated Show resolved Hide resolved
@tevesz tevesz changed the title CDP CDW create and delete hive virtual warehouse DWX-18731 CDP DW create and delete hive virtual warehouse Jun 28, 2024
vcsomor
vcsomor previously approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the first iteration

gregito
gregito requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things 🙂

resources/dw/resource_hive_vw.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw.go Outdated Show resolved Hide resolved
resources/dw/resource_hive_vw_acc_test.go Show resolved Hide resolved
Viktor Csomor and others added 4 commits July 8, 2024 08:24
@tevesz
CDPCP-11471 CDP DW PoC
4232115 
Add simple Hive VW Resource
@tevesz
Add hive dw virtual warehouse creation
4ccb136 
Added creation code, and tf file for testing. Tested creation and
deletion.
@tevesz
DWX-18731 Add hive creation and deletion tests
9eeeadc 
- acceptance tests
- unit tests
@tevesz
Fix review comments
d5530f2
@tevesz tevesz requested a review from gregito July 8, 2024 13:27
@gregito gregito merged commit 0def7a9 into cloudera:main Jul 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregito gregito gregito approved these changes

@vcsomor vcsomor vcsomor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevesz @gregito @vcsomor