[ui-storagebrowser] fixes the preview for non-text files #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
requested changes
Feb 3, 2025
| @@ -295,18 +305,18 @@ describe('StorageFilePage', () => { | |||
| expect(video.children[0]).toHaveAttribute('src', expect.stringContaining('videofile.mp4')); | |||
| }); | |||
|
|
|||
| it('should display a message for unsupported file types', () => { | |||
| it('should display a message for compresed file types', () => { | |||
| @@ -230,15 +230,25 @@ describe('StorageFilePage', () => { | |||
| expect(screen.queryByRole('link', { name: 'Download' })).toBeNull(); | |||
| }); | |||
|
|
|||
| // TODO: fix this test when mocking of useLoadData onSuccess callback is mproperly mocked | |||
| it.skip('should render a textarea for text files', () => { | |||
| // TODO: fix this test when mocking of useLoadData onSuccess callback is properly mocked | |||
There was a problem hiding this comment.
Why don't we mock this now?
| const fileExtension = fileName?.split('.')?.pop()?.toLowerCase(); | ||
| if (!fileExtension) { | ||
| return SupportedFileTypes.OTHER; | ||
| for (const fileExtension in SUPPORTED_FILE_EXTENSIONS) { |
There was a problem hiding this comment.
Why did you remove the split on "." lower case transformation? This seems less robust given that this function still receives the complete file name.
A file called "testpng" and that is lacking a proper file type will now be assumed to be a png file just because it has it in the name at the end. Also "test.PNG" which should be matched won't be matched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Dockerfile) was opened in the file browser, a message indicating "unsupported file type" was shown, which prevented users from viewing the content of the file, even if it contained readable text.How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.