Support expires_in as a number or string #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to get a refresh_token from login.microsoft.com would result
in the following error message.
failed to parse exchange response: json: cannot unmarshal string into Go struct field TokenResponse.expires_in of type int64
This happens because their API is returning `expires_in` as a JSON
string instead of as a JSON number as expected. It seems this is in
violation of the OAuth2 spec, but it's happening nonetheless.
This change allows `expires_in` to be accepted as an int64 whether it's
encoded as a JSON number or string.
mbilski
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to get a refresh_token from login.microsoft.com would result
in the following error message.
This happens because their API is returning
expires_inas a JSONstring instead of as a JSON number as expected. It seems this is in
violation of the OAuth2 spec, but it's happening nonetheless.
This change allows
expires_into be accepted as an int64 whether it'sencoded as a JSON number or string.