Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for private dns records #36

Merged
merged 8 commits into from
Nov 11, 2024
Merged

feat: Added support for private dns records #36

merged 8 commits into from
Nov 11, 2024

Conversation

13archit
Copy link
Member

@13archit 13archit commented Sep 11, 2024 •
edited
Loading

WHAT

  • Added support for private dns.
  • Update count condition for creation of resources. Added enable_private_dns and enable_public_dns variables to control the creation public and private DNS zone.
  • Renamed _example folder to examples.
  • Update CODEOWNERS.

WHY

  • Make users able to deploy private DNS zone with same module.
  • To support our readme workflow.

@clouddrove-ci clouddrove-ci self-assigned this Sep 11, 2024
d4kverma
d4kverma reviewed Sep 11, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@13archit 13archit requested a review from d4kverma September 12, 2024 13:03
@13archit 13archit self-assigned this Sep 12, 2024
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  

  


        
        @d4kverma
  d4kverma



        merged commit a693155
      into

      
  
    master
  


    Nov 11, 2024

      

        19 of 20 checks passed
      


      

        
          
  
    
    

        
      

  
















  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


      

          

  
      @d4kverma
  
    d4kverma


                Awaiting requested review from d4kverma


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
      @clouddrove-ci
  
    clouddrove-ci
    

      

      

        

  
      @13archit
  
    13archit
    

      








      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @13archit 
        
          @clouddrove-ci 
        
          @d4kverma