Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple #1

Merged
merged 6 commits into from
Nov 5, 2019
Merged

Simple #1

merged 6 commits into from
Nov 5, 2019

Conversation

nikitadugar
Copy link
Member

Make module in simplest form

sohanyadav
sohanyadav approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@sohanyadav sohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@nikitadugar nikitadugar merged commit 0f75198 into master Nov 5, 2019
@nikitadugar nikitadugar deleted the simple branch November 5, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohanyadav sohanyadav sohanyadav approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitadugar @sohanyadav