Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update github action and readme and terraform version #20

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: update github action and readme and terraform version #20

merged 2 commits into from
Oct 13, 2023

Conversation

mamrajyadav
Copy link
Contributor

what

  • update terraform and aws latest version.
  • update and add github action files
  • update latest readme.
  • fix tfsec and tflint warnings.
  • update example

@clouddrove-ci clouddrove-ci self-assigned this Oct 11, 2023
@nileshgadgi nileshgadgi self-requested a review October 13, 2023 17:57
nileshgadgi
nileshgadgi approved these changes Oct 13, 2023
View reviewed changes
Copy link

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vaibhav7797 vaibhav7797 self-requested a review October 13, 2023 17:59
@themaniskshah themaniskshah merged commit 163ddce into master Oct 13, 2023
@themaniskshah themaniskshah deleted the issue-288 branch October 13, 2023 17:59
vaibhav7797
vaibhav7797 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@nileshgadgi nileshgadgi nileshgadgi approved these changes

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

@d4kverma d4kverma Awaiting requested review from d4kverma

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

Assignees

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mamrajyadav @themaniskshah @vaibhav7797 @nileshgadgi @clouddrove-ci