Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for multiple log-groups for redis logs according to log_type #69

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Added support for multiple log-groups for redis logs according to log_type #69

merged 1 commit into from
Mar 13, 2024

Conversation

soumik-avoma
Copy link
Contributor

what

  • Added support for multiple log groups for redis logs according to log_type, this becomes necessary when we want to separate out the log-groups for better view of logs

why

  • The log separation is best for better readability and maintenance

vaibhav7797
vaibhav7797 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 6e9c57e into clouddrove:master Mar 13, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshgadgi nileshgadgi nileshgadgi approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@clouddrove-ci clouddrove-ci clouddrove-ci approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@themaniskshah themaniskshah Awaiting requested review from themaniskshah

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

@h1manshu98 h1manshu98 Awaiting requested review from h1manshu98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumik-avoma @clouddrove-ci @vaibhav7797 @nileshgadgi