Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added network_type variable and added support for ipv6 and dual_stack for redis #68

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Added network_type variable and added support for ipv6 and dual_stack for redis #68

merged 1 commit into from
Mar 13, 2024

Conversation

soumik-avoma
Copy link
Contributor

what

  • Added support for ipv6 in redis cluster

why

  • Since AWS has started charging for public ipv4, hence many organizations are moving to ipv6 adoption. So Redis also needs to be in ipv6 to avoid delay and implement happy eyeballs if required.

references

vaibhav7797
vaibhav7797 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

themaniskshah
themaniskshah approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit c7422b5 into clouddrove:master Mar 13, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshgadgi nileshgadgi nileshgadgi approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@clouddrove-ci clouddrove-ci clouddrove-ci approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

@h1manshu98 h1manshu98 Awaiting requested review from h1manshu98

@13archit 13archit Awaiting requested review from 13archit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soumik-avoma @themaniskshah @clouddrove-ci @vaibhav7797 @nileshgadgi