fix: support dynamic version in url

cloudbeds · Jun 15, 2023 · cbd0cd7 · cbd0cd7
1 parent 56c4549
commit cbd0cd7
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 6 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -8,7 +8,12 @@ export const DEFAULT_DIR_DOWNLOADED_TYPES = `src/@types/remotes`;
 
 export const DEFAULT_DOWNLOAD_TYPES_INTERVAL_IN_SECONDS = 60;
 
-export const CLOUDBEDS_DEV_FRONTEND_ASSETS_DOMAIN = 'https://cb-front.cloudbeds-dev.com';
+export enum CloudbedsCloudfrontDomain {
+  Dev = 'https://cb-front.cloudbeds-dev.com',
+  Stage = 'https://cb-front.stage-ga.cloudbeds-dev.com',
+  Prod = 'https://front.cloudbeds.com',
+}
+
 /** @deprecated */
 export const CLOUDBEDS_MFD_COMMON_MANIFEST_FILE_NAME = 'mfd-common-remote-entry.json';
 export const CLOUDBEDS_REMOTES_MANIFEST_FILE_NAME = 'remote-entries.json';

diff --git a/src/helpers/cloudbedsRemoteManifests.ts b/src/helpers/cloudbedsRemoteManifests.ts
@@ -1,5 +1,5 @@
 import {
-  CLOUDBEDS_DEV_FRONTEND_ASSETS_DOMAIN,
+  CloudbedsCloudfrontDomain,
   CLOUDBEDS_MFD_COMMON_MANIFEST_FILE_NAME,
   CLOUDBEDS_REMOTES_MANIFEST_FILE_NAME,
   CloudbedsMicrofrontend,
@@ -9,9 +9,14 @@ import { ModuleFederationTypesPluginOptions, RemoteManifestUrls } from '../types
 export function getRemoteManifestUrls(options?: ModuleFederationTypesPluginOptions): RemoteManifestUrls | undefined {
   if (options?.cloudbedsRemoteManifestsBaseUrl !== undefined) {
     let baseUrl = options?.cloudbedsRemoteManifestsBaseUrl;
-    if (!baseUrl || baseUrl === 'use-domain-name' || baseUrl === 'dev-ga') {
-      baseUrl = `${CLOUDBEDS_DEV_FRONTEND_ASSETS_DOMAIN}/remotes/dev-ga`;
+    if (!baseUrl || ['use-domain-name', 'dev', 'dev-ga'].includes(baseUrl)) {
+      baseUrl = `${CloudbedsCloudfrontDomain.Dev}/remotes/dev-ga`;
+    } else if (['stage', 'stage-ga'].includes(baseUrl)) {
+      baseUrl = `${CloudbedsCloudfrontDomain.Stage}/remotes/stage-ga/{version}`;
+    } else if (['prod', 'prod-ga'].includes(baseUrl)) {
+      baseUrl = `${CloudbedsCloudfrontDomain.Prod}/remotes/prod-ga/{version}`;
     }
+
     return {
       /** @deprecated */
       [CloudbedsMicrofrontend.Common]: `${baseUrl}/${CLOUDBEDS_MFD_COMMON_MANIFEST_FILE_NAME}`,

diff --git a/src/helpers/downloadTypes.ts b/src/helpers/downloadTypes.ts
@@ -11,6 +11,11 @@ import { toCamelCase } from './toCamelCase';
 const downloadOptions: download.DownloadOptions = { rejectUnauthorized: false };
 
 async function downloadRemoteEntryManifest(url: string): Promise<unknown> {
+  if (url.includes('{version}')) {
+    const versionJsonUrl = `${url.match(/^https:\/\/[^/]+/)}/version.json`;
+    const { version } = JSON.parse((await download(versionJsonUrl, downloadOptions)).toString());
+    url.replace('{version}', version);
+  }
   const json = (await download(url, downloadOptions)).toString();
   return JSON.parse(json);
 }
@@ -121,7 +126,11 @@ export async function downloadTypes(
   Object.entries(remotesFromFederationConfig).forEach(([remoteName, remoteLocation]) => {
     try {
       const remoteEntryUrl = remoteEntryUrlsResolved[remoteName] || remoteLocation.split('@')[1];
-      const remoteEntryBaseUrl = remoteEntryUrl.split('/').slice(0, -1).join('/');
+
+      const remoteEntryBaseUrl = remoteEntryUrl.endsWith('.js')
+        ? remoteEntryUrl.split('/').slice(0, -1).join('/')
+        : remoteEntryUrl;
+
       const promiseDownload = downloadRemoteEntryTypes(
         remoteName,
         remoteLocation,

diff --git a/src/types.ts b/src/types.ts
@@ -38,5 +38,8 @@ export type ModuleFederationTypesPluginOptions = {
   remoteManifestUrls?: RemoteManifestUrls,
   remoteManifestUrl?: string,
 
-  cloudbedsRemoteManifestsBaseUrl?: string | /** @deprecated */ 'use-domain-name' | 'dev-ga',
+  cloudbedsRemoteManifestsBaseUrl?: string | /** @deprecated */ 'use-domain-name'
+    | 'dev' | 'dev-ga'
+    | 'stage' | 'stage-ga'
+    | 'prod' | 'prod-ga',
 }