Fixes install procedure for linux #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make build needs ~/.terraform/plugins to be present, so it is created * make build need bin/ to be present, but the need is removed * make release needs the bin/releases directories, so they are created Fixes cloudamqp#26
…hat things are happening
* Use go get instead of manually downloading and manually creating everything * Substitute make init with make install
dentarg
pushed a commit
that referenced
this pull request
Jun 5, 2024
Adds retry functionality when waiting on peering status. Issue reported for AWS when provisioning multiple instances, vpcs and peerings. * Add retry functionality to wait for peering status * Re-use wait for peering status in vpc_peering.go * Refactor vpc_peering.go * Refactor vpc_peering_withvpcid.go
dentarg
pushed a commit
that referenced
this pull request
Jun 5, 2024
Adds retry functionality when waiting on peering status. Issue reported for AWS when provisioning multiple instances, vpcs and peerings. * Add retry functionality to wait for peering status * Re-use wait for peering status in vpc_peering.go * Refactor vpc_peering.go * Refactor vpc_peering_withvpcid.go
dentarg
pushed a commit
that referenced
this pull request
Jun 5, 2024
Adds retry functionality when waiting on peering status. Issue reported for AWS when provisioning multiple instances, vpcs and peerings. * Add retry functionality to wait for peering status * Re-use wait for peering status in vpc_peering.go * Refactor vpc_peering.go * Refactor vpc_peering_withvpcid.go
dentarg
pushed a commit
that referenced
this pull request
Jun 5, 2024
Adds retry functionality when waiting on peering status. Issue reported for AWS when provisioning multiple instances, vpcs and peerings. * Add retry functionality to wait for peering status * Re-use wait for peering status in vpc_peering.go * Refactor vpc_peering.go * Refactor vpc_peering_withvpcid.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Hey there, when installing the CloudAMQP provider plugin i bumped into a few things in the install steps that didn't really work on my linux system, and some things that seemed off about the documentation and things around the project.
buildandreleasemake targets will now be created before they are needed. (If they already exist, nothing happens)make depsupdatetarget at all. Note: I have not validated that all the package versions are compatible and that everything works. I beleive that the Gopkg.lock file should be checked in, so that the version sets are not changing without the devs actually having made sure that the newer versions work.-vflag to the command that is run bymake depsupdateso that the user can see that things are happening. (The command ran for a long time for me and i wasn't sure if anything was actually happening)make inittomake installsince i don't really understand what we are trying to do with the init...I hope that at least most of this is useful. Please feel free to ask questions or challange what i am suggesting. Cheers and thanks! :)