Use the API backend for online validation #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbroden84
changed the title
tbroden84
commented
Apr 21, 2023
docs/guides/info_plan.md
Outdated
| ```shell | ||
| # Filter out available plans for RabbitMQ | ||
| curl -u :xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxxx \ | ||
| https://customer.cloudamqp.com/api/plans?backend=rabbitmq |
There was a problem hiding this comment.
Each of these examples with filtered requests would require: https://github.com/84codes/customer-console/pull/164
Or if we should just reference our docs.cloudamqp.com.
There was a problem hiding this comment.
Yes we should document it there and reference it
dentarg
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change plan and region validation to no longer use hardcoded values in the provider. Instead use the API backend to do the validation. The plans are validated against each team, in regards to any specific feature flags set, such as preview plans without the need to update the provider. Therefore will now also support all new LavinMQ dedicated plans.
The validation only occurs when plan or region are changed from earlier state, during create or plan/region update.
More changes done in this PR.
Testing requires: 84codes/go-api#34