Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credential assignment when using tags (#195) #196

Closed
wants to merge 1 commit into from

Conversation

seanson
Copy link

@seanson seanson commented Mar 23, 2023

Fixes #195

@seanson
Copy link
Author

seanson commented Mar 23, 2023

Tested and working locally with tag creation.

Tested and actually working locally with resource creation and editing.

@seanson seanson marked this pull request as draft March 24, 2023 00:24
@seanson seanson force-pushed the 195_credential_tags branch from 18bc259 to 5c611ac Compare March 24, 2023 00:35
@seanson seanson marked this pull request as ready for review March 24, 2023 00:35
@dentarg dentarg requested a review from tbroden84 March 27, 2023 07:41
@dentarg
Copy link
Member

dentarg commented Mar 27, 2023

Looks like a regression from 4c7b852?

@tbroden84
Copy link
Contributor

@seanson Thanks for the contribution. While testing and using queue_allowlist and vhost_allowlist, they also got assigned the wrong values but without any errors. This was introduced into 4c7b852. Created a new PR: #198 to handle all three optional arguments (queue_allowlist, vhost_allowlist and tags). Will close this and merge the other instead.

@tbroden84 tbroden84 closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating or updating cloudamqp_integration_metric with tags is failing
3 participants