Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Fix custom rule/target file copy #132

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Fix custom rule/target file copy #132

merged 1 commit into from
Jul 15, 2018

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Jul 15, 2018

[patch]
Remove placeholder dirs as they cause Ansible to ignore local files
dirs. Simplify fileglob by only copying valid filenames.

Signed-off-by: Ben Kochie [email protected]

@SuperQ SuperQ requested a review from paulfantom July 15, 2018 17:25
paulfantom
paulfantom previously approved these changes Jul 15, 2018
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulfantom
Copy link
Member

Remember to add one of supported identifiers, like [patch] in merge commit message since [bugfix] is not supported

[patch]

Remove placeholder dirs as they cause Ansible to ignore local files
dirs. Simplify fileglob by only copying valid filenames.

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ
Copy link
Collaborator Author

SuperQ commented Jul 15, 2018

Fixed up with [patch]. :)

@SuperQ SuperQ merged commit 47c72e9 into master Jul 15, 2018
@SuperQ SuperQ deleted the superq/fix_rules branch July 15, 2018 18:34
slomo pushed a commit to slomo/ansible-prometheus that referenced this pull request Dec 12, 2018
[patch]

Remove placeholder dirs as they cause Ansible to ignore local files
dirs. Simplify fileglob by only copying valid filenames.

Signed-off-by: Ben Kochie <[email protected]>
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants