This repository has been archived by the owner on May 31, 2023. It is now read-only.
Avoid being clever about unsupported architectures #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when different packages sources where used to install Grafana, it made sense to fail fast, if there where no supported package. But now Grafana supports many architecture directly and this pre-flight check hinders installation on aarch64. Removing this check, delegating the failure to the package installer, simplifies the installation.
|
Thanks 👍 |
cosandr
pushed a commit
to cosandr/ansible-grafana
that referenced
this pull request
Aug 12, 2020
Previously, when different packages sources where used to install Grafana, it made sense to fail fast, if there where no supported package. But now Grafana supports many architecture directly and this pre-flight check hinders installation on aarch64. Removing this check, delegating the failure to the package installer, simplifies the installation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when different packages sources where used to install Grafana,
it made sense to fail fast, if there where no supported package. But now
Grafana supports many architecture directly and this pre-flight check
hinders installation on aarch64. Removing this check, delegating the
failure to the package installer, simplifies the installation.