refactor: ⚰️ remove contributorId, unused key

cloud-pi-native · Jun 1, 2023 · 9edc04f · 9edc04f
1 parent 626c031
commit 9edc04f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/apps/server/src/models/organization.js b/apps/server/src/models/organization.js
@@ -10,10 +10,6 @@ export const getOrganizationModel = () => Organization ?? (Organization = sequel
     unique: true,
     defaultValue: DataTypes.UUIDV4,
   },
-  contributorId: {
-    type: DataTypes.STRING(50),
-    unique: true,
-  },
   source: {
     type: DataTypes.STRING(50),
   },

diff --git a/packages/shared/src/schemas/organization.js b/packages/shared/src/schemas/organization.js
@@ -4,8 +4,6 @@ export const organizationSchema = Joi.object({
   id: Joi.string()
     .uuid(),
 
-  contributorId: Joi.string(),
-
   source: Joi.string(),
 
   name: Joi.string()

diff --git a/packages/shared/src/utils/schemas.spec.js b/packages/shared/src/utils/schemas.spec.js
@@ -59,7 +59,6 @@ describe('Schemas utils', () => {
   it('Should validate a correct organization schema with external data', () => {
     expect(schemaValidator(organizationSchema, {
       id: faker.datatype.uuid(),
-      contributorId: faker.word.noun(),
       source: faker.word.noun(),
       name: faker.word.noun(),
       label: faker.company.name(),
@@ -89,12 +88,11 @@ describe('Schemas utils', () => {
   it('Should not validate an organization schema with wrong external data', () => {
     expect(schemaValidator(organizationSchema, {
       id: faker.datatype.uuid(),
-      contributorId: faker.datatype.array(),
-      source: faker.word.noun(),
+      source: faker.datatype.array(),
       name: faker.word.noun(),
       label: faker.company.name(),
       active: faker.datatype.boolean(),
-    })).toStrictEqual({ contributorId: '"contributorId" must be a string' })
+    })).toStrictEqual({ source: '"source" must be a string' })
   })
 
   it('Should not validate schema and send specific error', () => {