ptfs: use BorrowedFd instead of RawFd when possible #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
bergwolf,
imeoer,
liubogithub and
eryugey
as code owners
eryugey
reviewed
Nov 7, 2023
src/passthrough/mod.rs
Outdated
| @@ -272,8 +282,8 @@ impl HandleData { | |||
| // object is within scope. Otherwise it may cause race window to access wrong target fd. | |||
| // By introducing this method, we could explicitly audit all callers making use of the | |||
| // underlying RawFd. | |||
There was a problem hiding this comment.
The comments above are still referencing RawFd, these should be updated as well?
Also, it'd be better to describe why we're replacing RawFd with BorrowedFd in commit log, what are the benefits.
Use BorrowedFd instead of RawFd when possible. By using BorrowedFd we can explicitly manage the lifetime of the underlying RawFd, to avoid misusing after file close. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
borrowed-fd
branch
from
0dfff51
to
ffe00df
Compare
eryugey
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use BorrowedFd instead of RawFd when possible.