Optimize implementation of lookup() for passthroughfs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
bergwolf,
imeoer,
liubogithub and
eryugey
as code owners
jiangliu
force-pushed
the
ptfs-lookup
branch
23 times, most recently
from
868f62c to
217a8aa
Compare
bergwolf
reviewed
Nov 2, 2023
Optimize implementation of do_lookup() by: - use statx() instead of fsstat64() when possible to get stat with mount id - create openable handle on demand, avoid unnecessary operations - remove InodeStat, using StatExt instead - remove function stat() and open_proc_file() Signed-off-by: Jiang Liu <[email protected]>
Optimize implementation of open_inode() by avoid double opening in case for FileHandle. Signed-off-by: Jiang Liu <[email protected]>
Make use of helpers from util. Signed-off-by: Jiang Liu <[email protected]>
bergwolf
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize implementation of lookup() for passthroughfs.