abi: Disable unsupported flags and functionality on MacOS #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griff
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
|
I could also add the MacFUSE specific flags to this PR if you want them. |
|
oh, that's a lot of |
|
@bergwolf That is really up to you. If you want it split I will split it. |
|
@griff Please help to split it, thanks! I think it makes the code more clear. |
It would better to split for archs. |
MacFUSE is a fork of FUSE version 19 with its own custom flags that sometimes clash with later versions of FUSE. E.g. INIT_EXT flags clashes with MacFUSE flag VOL_RENAME. So to avoid confussion this change splits fuse_abi into fuse_abi_linux and fuse_abi_macos and hopefully disables all functionality not supported on MacOS. This applies both to MacFUSE and FUSE-T because FUSE-T is built to be compatible with MacFUSE and not upstream FUSE. Signed-off-by: Brian Olsen <[email protected]>
Done |
jiangliu
approved these changes
Oct 25, 2023
jiangliu
added a commit
to jiangliu/fuse-backend-rs
that referenced
this pull request
Oct 26, 2023
Clean up code related to macos. Follow up of cloud-hypervisor#162 Signed-off-by: Jiang Liu <[email protected]>
jiangliu
added a commit
to jiangliu/fuse-backend-rs
that referenced
this pull request
Oct 26, 2023
Clean up code related to macos. Follow up of cloud-hypervisor#162 Signed-off-by: Jiang Liu <[email protected]>
jiangliu
added a commit
to jiangliu/fuse-backend-rs
that referenced
this pull request
Oct 26, 2023
Clean up code related to macos. Follow up of cloud-hypervisor#162 Signed-off-by: Jiang Liu <[email protected]>
eryugey
pushed a commit
that referenced
this pull request
Oct 27, 2023
Clean up code related to macos. Follow up of #162 Signed-off-by: Jiang Liu <[email protected]>
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Dec 16, 2023
The fix mentioned in Cargo.toml did land in cloud-hypervisor/fuse-backend-rs#162. Change-Id: I4451f910806f05400f7e0f83581ae786f170b9e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10375 Autosubmit: flokli <[email protected]> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacFUSE is a fork of FUSE version 19 with its own custom flags that sometimes clash with later versions of FUSE. E.g. INIT_EXT flags clashes with MacFUSE flag VOL_RENAME.
So to avoid confussion this change disables all flags and hopefully all functionality not supported on MacOS. This applies both to MacFUSE and FUSE-T because FUSE-T is built to be compatible with MacFUSE and not upstream FUSE.