linux_session: Make allow_other mount option optional #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrewster
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
cbrewster
force-pushed
the
optional-allow_other
branch
3 times, most recently
from
b553ce5
to
55d4d92
Compare
|
MacOS failures seem unrelated. |
jiangliu
approved these changes
Sep 20, 2023
Yes, it's independent of this PR and just get fixed. |
The `allow_other` mount option typically requires root user permissions unless configured otherwise on the machine. It would be nice if this was configurable to allow for unprivileged mounting. For non-root users to use this option the system must have 'user_allow_other' set in /etc/fuse.conf. Signed-off-by: Connor Brewster <[email protected]>
cbrewster
force-pushed
the
optional-allow_other
branch
from
55d4d92
to
17c8078
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allow_othermount option typically requires root user permissions unless configured otherwise on the machine. It would be nice if this was configurable to allow for unprivileged mounting.For non-root users to use this option the system must have 'user_allow_other' set in /etc/fuse.conf.