passthrough: validate config regarding to cache mode #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eryugey
requested review from
bergwolf,
imeoer,
jiangliu and
liubogithub
as code owners
Kernel fuse module defaults to KEEP_CACHE in no_open mode, and passthroughfs only sets KEEP_CACHE in cache=always mode. So we should reject no_open if cache is not always. Also disable writeback cache if cache=none, as we should disable all cache in cache=none mode. Signed-off-by: Eryu Guan <[email protected]>
jiangliu
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel fuse module defaults to KEEP_CACHE in no_open mode, and passthroughfs only sets KEEP_CACHE in cache=always mode. So we should reject no_open if cache is not always.
Also disable writeback cache if cache=none, as we should disable all cache in cache=none mode.