feat: implement fuse-t feature #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
killagu
force-pushed
the
feat/fuse-t
branch
3 times, most recently
from
d735bfa
to
9806669
Compare
bergwolf
reviewed
Jul 25, 2023
| @@ -51,6 +51,7 @@ async-io = ["async-trait", "tokio-uring", "tokio/fs", "tokio/net", "tokio/sync", | |||
| fusedev = ["vmm-sys-util", "caps", "core-foundation-sys"] | |||
| virtiofs = ["virtio-queue", "caps", "vmm-sys-util"] | |||
| vhost-user-fs = ["virtiofs", "vhost", "caps"] | |||
| fuse-t=[] | |||
There was a problem hiding this comment.
should be a feature only available on macos?
There was a problem hiding this comment.
Yes, but features not support [target.'cfg(target_os = "macos")'.features]?
tests/macfuse_smoke.rs
Outdated
| @@ -53,7 +53,7 @@ mod macfuse_tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[ignore] // it depends on privileged mode to pass through /dev/fuse | |||
| #[cfg(feature = "fuse-t")] // it depends on privileged mode to pass through /dev/fuse | |||
There was a problem hiding this comment.
we use --ignore to test with privilege mode.
There was a problem hiding this comment.
This case only run macos, has no --ignore run.
There was a problem hiding this comment.
macfuse can not get privilege, becase it must click in System Setting.
bergwolf
reviewed
Aug 1, 2023
| const FUSE_HEADER_SIZE: usize = 0x1000; | ||
| const FS_SND_SIZE: usize = 4 * 1024 * 1024; | ||
|
|
||
| const FUSE_NFSSRV_PATH: &str = "/usr/local/bin/go-nfsv4"; |
There was a problem hiding this comment.
Is the binary installed by default? I don't see it getting installed in the test setup.
There was a problem hiding this comment.
Install by this script
wget https://github.com/macos-fuse-t/fuse-t/releases/download/1.0.24/fuse-t-macos-installer-1.0.24.pkg
sudo installer -pkg fuse-t-macos-installer-1.0.24.pkg -target /
|
There are a few warnings: Not sure why CI didn't catch it. Otherwise lgtm! |
Use fuse-t to replace MacFUSE as the implementation of FUSE. fuse-t is based on NFS and does not require the use of kernel extensions. Installation can be done with lower privileges and it does not impact system stability. Signed-off-by: killagu <[email protected]>
|
Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fuse-t to replace MacFUSE as the implementation of FUSE. fuse-t is based on NFS and does not require the use of kernel extensions. Installation can be done with lower privileges and it does not impact system stability.