Derive Default for CachePolicy (and update Rust CI version) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to `cargo clippy` for the suggestion. See https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls for background.
matthiasgoergens
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
The ci of docker-smoke gets errors otherwise:
````
error[E0658]: deriving `Default` on enums is experimental
--> src/passthrough/mod.rs:345:17
|
345 | #[derive(Debug, Default, Clone, Eq, PartialEq)]
| ^^^^^^^
|
= note: see issue #86985 <rust-lang/rust#86985> for more information
= note: this error originates in the derive macro `Default` (in Nightly builds, run with -Z macro-backtrace for more info)
For more information about this error, try `rustc --explain E0658`.
error: could not compile `fuse-backend-rs` due to previous error
make: *** [Makefile:4: build] Error 101
make: *** [Makefile:44: docker-smoke] Error 2
```
matthiasgoergens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to
cargo clippyfor the suggestion.See
https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls for background.
Edit: we also need to update our CI's version of Rust, as the necessary feature has only been stabilized recently.