Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to 11ty, basic home page setup, broad strokes migrating styles. #2

Closed
wants to merge 7 commits into from

Conversation

jamesthebrooks
Copy link
Contributor

Changes proposed in this pull request:

  • init setup on 11ty pages template
  • init home page migration
  • init styles migration and setup

security considerations

n/a

Copy link

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I just commented on a fontawesome dependency listed that we don't need to use. Uninstall and rebuild the lock file and I think we should be good to go.

package.json Outdated
@@ -44,6 +44,7 @@
"rimraf": "^6.0.1"
},
"dependencies": {
"@fortawesome/fontawesome-free": "^6.6.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be using font awesome. If we need iconography, let's use USWDS's icons.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What andrew said ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. We do use them here:

  • Documentation navigation
  • Highlights
  • Sidenav

I haven't finished rebuilding that in 11ty yet anyway, so I'll remove the dependency for now and get back to the sidenav in a future update.

{% image_with_class "./_img/logo-img.png" "width-10 height-auto" "Agency logo" %}
</a>
</div>
<div class="footer-section-bottom usa-footer__primary-section bg-accent-warm-light border-top border-accent-warm-dark">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this footer populated by a yaml list in the _data folder rather than hardcoded values.

========================================
========================================
----------------------------------------
USWDS 2.13.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is USWDS 2, not 3. is that intentional?

documentation_navigation:
- name: "Overview"
identifier: "overview"
icon: fa-home
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remap these to the USWDS icon names, you can keep this general structure. Although i'd rather these came from the front matter of the files or data files in the folders, rather than listed separately

@jamesthebrooks jamesthebrooks changed the title Overhaul Migration to 11ty, basic home page setup, broad strokes migrating styles. Oct 10, 2024
@jamesthebrooks jamesthebrooks deleted the overhaul branch October 10, 2024 14:22
jamesthebrooks added a commit that referenced this pull request Oct 16, 2024
1. Migration to 11ty, basic home page setup, broad strokes migrating styles. #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants