Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Test shared user org select #4667 #4684

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: Test shared user org select #4667 #4684

merged 1 commit into from
Nov 26, 2024

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Nov 25, 2024 •
edited
Loading

Closes #4667

Changes proposed in this pull request:

  • Remove's default props and adds defaults to function args
  • Fixes htmlFor to use the id prop
  • Adds tests for select

security considerations

None

@cloud-gov-pages-operations
Copy link
Contributor

🤖 This is an automated code coverage report

Total coverage (lines): 14.83%
Coverage diff: 0.27% 📈

@apburnes apburnes force-pushed the chore-test-shared-user-org-select branch from 8fd9e53 to 2ebbd27 Compare November 25, 2024 22:49
@apburnes apburnes requested a review from a team November 25, 2024 23:08
drewbo
drewbo requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small items but looks good

frontend/shared/UserOrgSelect.jsx Outdated Show resolved Hide resolved
frontend/shared/UserOrgSelect.test.jsx Outdated Show resolved Hide resolved
@apburnes apburnes force-pushed the chore-test-shared-user-org-select branch from 2ebbd27 to b5e6e1c Compare November 26, 2024 15:20
@apburnes apburnes requested a review from drewbo November 26, 2024 15:32
@apburnes apburnes merged commit 8b11233 into main Nov 26, 2024
8 checks passed
@apburnes apburnes deleted the chore-test-shared-user-org-select branch November 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo drewbo approved these changes

Assignees
No one assigned
Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RTL tests to @shared/UserOrgSelect.jsx
3 participants
@apburnes @cloud-gov-pages-operations @drewbo