This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Global notification and button refactoring #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msecret
force-pushed
the
ms-global_error
branch
from
6a86bf1 to
41301c6
Compare
added 4 commits
February 21, 2017 15:37
Try at global error design component. I think this needs some design review before going too much further.
To have a outline button with transparent background of the color of the notification. To get this to work, I did some work to remove the massive amount of specificity in the buttons. This was mainly done by removing the dependency on the `usa-button` classes which have too much specificty. I also ensured the styleguide uses unmin css because even in production it seems more useful. This is a breaking change.
As this will go in a separate branch for a larger release
The 18f styline "name-format" plugin does not work correctly because the mixin in `actions.scss` complies with it but it still reports an error. I disabled it until that could be fixed.
adborden
approved these changes
Feb 22, 2017
| @@ -2,7 +2,7 @@ | |||
| <html> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <link media="all" rel="stylesheet" href="{{ '/css/cloudgov-style-min.css' | path }}"> | |||
| <link media="all" rel="stylesheet" href="{{ '/css/cloudgov-style.css' | path }}"> | |||
There was a problem hiding this comment.
Hmm, does this simplify the build at all? I think we can drop the compile-css step from https://github.com/18F/cg-style/pull/308/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R16
Can be removed because we're not included compiled assets anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new prototype notification feature. This is meant to provide feedback about errors and other things to the user on a global level. It's required for the global error handling in the dashboard. It has different parts to it, wrap, message, actions, and dismiss. It also has modifiers; warning, info, error, finish, that link to the existing states in the design system.
The button code was refactored to make it easier to add the action buttons to the notification panel. No code needs to be changed for this to work, but eventually we should remove
usa-buttoncode in both cg-site and cg-dashboard. This should be done in a separate PR and go into a large release.