This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Fix color contrast issues in text #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The success button green is too light and the gray for the paths in the quicklooks is too light of a gray. Dano mentioned he wanted a different solution for the green but I think we should fix accessibility issues as soon as possible.
|
I'm okay with the grey space text change, but the green color looks too dark. Especially for the icon and the status-pill. I think it's okay to go dark green for contrast regarding text, but I don't think we should make the change across the board. Generally I don't think any of the green text is critical for accessibility so I would rather hold off on the green change for now and wait until we have a more complete color palette solution. |
As the darker green is too dark for the icons and status UI.
|
Even though the green status text isn't that important, I'm still not sure I want to leave it inaccessible. If somebody has trouble reading it, they might not know it's not important. I separate the green text color from the rest of the green. |
adborden
approved these changes
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The success button green is too light and the gray for the paths
in the quicklooks is too light of a gray.
Dano mentioned he wanted a different solution for the green but I
think we should fix accessibility issues as soon as possible.
Refs cloud-gov/cg-dashboard#921