This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Refactor usage and limits #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing panel code and making the stat component much more specific. Rather then making the stat component able to adapt to many different sizes, it sets all the sizes of things. This makes it much easier to build and I'm not sure the adaptability will be required for this component anyway.
By insuring the logo has enough room and the error takes up the rest of the space.
adborden
approved these changes
Feb 8, 2017
|
|
||
| .error-inline { | ||
| width: auto; | ||
| } |
There was a problem hiding this comment.
I feel like this is the common case, we want .error-inline to be width: auto in most places. I think the one exception is in form elements, but I'm not sure. Can we un-nest this rule?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing panel code and making the stat component much more
specific. Rather then making the stat component able to adapt
to many different sizes, it sets all the sizes of things. This
makes it much easier to build and I'm not sure the adaptability
will be required for this component anyway.