Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Added style for bordered panel row and lighter panel title weight #215

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

line47
Copy link

@line47 line47 commented Dec 13, 2016

Added style for bordered panel row and lighter panel title weight.

margin-bottom: 2rem;

h1,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, panel title is applied directly to the h tag, so this shouldn't be needed.

<h1 className={ this.styler('panel-title') }>{ this.props.title }</h1>

@@ -80,6 +91,12 @@ h4 + .panel {
margin: 1rem -1rem -1rem;
padding: 1rem;
width: 100%;

.route-form-preview {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually go in the dashboard code:

https://github.com/18F/cg-dashboard/blob/067ef8fe56532ed2e032a18be9ad53b357d11586/static_src/css/route_form.css

I mean, technically it should go in cg-style, but we don't have a place for it yet, so it would do better there for now.

Currently, the route form stuff is in the CSS files in dashboard,
so moved that there.

The h rules weren't required because of the way we're using the
title class.
@msecret msecret merged commit 262bd0b into master Dec 14, 2016
@msecret msecret deleted the ssw-route-styles branch December 14, 2016 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants