This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Panel upgrades #152
Merged
Panel upgrades #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes typography in the panel to match new designs, adding colors, etc.
Moves confirmation box from actions to it's own component and fixes the combinations of colors for button styles. TODO actions need to be refactored.
Confirmation box
jcscottiii
reviewed
Sep 26, 2016
| @@ -2,6 +2,7 @@ | |||
| @import 'actions.scss'; | |||
| @import 'activity_log.scss'; | |||
| @import 'billboard.scss'; | |||
| @import 'confirm'; | |||
jcscottiii
reviewed
Sep 26, 2016
| width: 100%; | ||
| } | ||
|
|
||
| .confirm-nexto { |
There was a problem hiding this comment.
It should be that because that would mean to is an element or modifier, wheresas "next to" is the modifier.
jcscottiii
reviewed
Sep 26, 2016
| } | ||
|
|
||
| /* TODO refactor all actions */ |
There was a problem hiding this comment.
refactor how so? or put a link to an issue here.
thinking about if another dev came in, would they know what to do
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes typography in the panel to match new designs, adding colors,
etc.
Should be minor version change.