Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Cloud.gov search bar styles #136

Merged
merged 14 commits into from
Sep 27, 2016
Merged

Cloud.gov search bar styles #136

merged 14 commits into from
Sep 27, 2016

Conversation

juliaelman
Copy link
Contributor

@juliaelman juliaelman commented Sep 2, 2016

This pull request is the continuation of the work started in this pull request (thank you @jcscottiii!). Below is the comp provided by @thisisdano on how the layout and interaction should function.

The integration of search for the docs is also started here and will be directly effected by the completion of this work.

cc0cee96-7026-11e6-8c01-741ac1cbc222

James C. Scott and others added 4 commits May 9, 2016 17:48
@msecret
Copy link

msecret commented Sep 2, 2016

We haven't been good about putting this is the instructions and reminding people about it, but did you run npm run lint?


[type='search'],
.search-field {
-webkit-appearance: none;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do again? There's also https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance. Should we just do appearance and auto-prefixer will take care of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msecret just putting a note here, this is still a WIP pull request and will most likely refactor this code.

However yes, this should change to appearance and let auto-prefixer do it's magic ✨

@juliaelman
Copy link
Contributor Author

@msecret yup! There is also some refactoring of this code, as you outlined in #64 that needs to be done too - hence the WIP.

@juliaelman
Copy link
Contributor Author

And just want to note here, this also reinforces my dislike for [WIP] pull requests for a few reasons:

  1. When should the pull request be reviewed? How do folks get notified?
  2. Could this potentially cause issues for feature bloat?

Going to continue to try it out, as it's a typical workflow used around 18F. However, I am going to noodle on how we might make this workflow more efficient.

@juliaelman juliaelman changed the title [WIP] Cloud.gov search bar styles Cloud.gov search bar styles Sep 27, 2016
@msecret msecret merged commit e29c975 into master Sep 27, 2016
@msecret msecret deleted the je-search_bar branch September 27, 2016 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants