-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This will allow for room between the search bar and the nav words
We haven't been good about putting this is the instructions and reminding people about it, but did you run |
|
||
[type='search'], | ||
.search-field { | ||
-webkit-appearance: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do again? There's also https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance. Should we just do appearance
and auto-prefixer will take care of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msecret just putting a note here, this is still a WIP pull request and will most likely refactor this code.
However yes, this should change to appearance
and let auto-prefixer do it's magic ✨
And just want to note here, this also reinforces my dislike for [WIP] pull requests for a few reasons:
Going to continue to try it out, as it's a typical workflow used around 18F. However, I am going to noodle on how we might make this workflow more efficient. |
This pull request is the continuation of the work started in this pull request (thank you @jcscottiii!). Below is the comp provided by @thisisdano on how the layout and interaction should function.
The integration of search for the docs is also started here and will be directly effected by the completion of this work.