webpack: ignore node_modules in any dir, not root #1267
Conversation
In our cloud.gov.au skin, we have a node_modules directory. Prior to this change, we would encounter an error building the application because of the descendent node_modules directory. With this change, any node_modules directory in the tree will be ignored.
|
@jcscottiii ready for review |
|
Thank you @jonathaningram! @jcscottiii is currently on vacation, so our cloud.gov team may not be able to get to reviewing these PRs until late next week or the week after. (In the meantime, a tiny note from me as another cloud.gov team member - it is super wonderful to see this work and we appreciate it! I shared a little bit about this internally with our 18F Open Source Working Group as an example of exactly the kind of collaboration and reuse that 18F hopes for with our open source policy, and with our advocacy for open source work in government in general. ❤️ ) |
|
Hello @brittag - thank you for your kind message. I appreciate you getting in touch :) No worries about the PR reviews - we really appreciate the time you and your team is giving to it. 👊 |
In our cloud.gov.au skin, we have a node_modules directory. Prior to
this change, we would encounter an error building the application
because of the descendent node_modules directory. With this change, any
node_modules directory in the tree will be ignored.