-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one question!
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "cloudgov-dashboard", | |||
"version": "1.16.9", | |||
"version": "1.16.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, at what point do we roll this over to the next minor version? Do we stop at 10 or do we just stop when we feel like we've added a more significant piece of functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll bump it next major feature for the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what about the next minor version? For example, when does it become 1.17.0
vs 1.16.11
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the next major feature will go to 1.17.0. Right now since we're doing mostly bug fixes, that's why i'm only bumping the patch number.
More about it here: https://github.com/18F/cg-dashboard/blob/adae679b1a7bb0611e2e02f5851cdfd9f786b350/RELEASE.md#updating-version-number
(Also, I think we may have messed up because we should've bumped minor when we did the user invite flow a few PIs ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I guess my question and/or example weren't clear. I was asking about minor, not major versions. But it seems like it's entirely up to the person doing the version bumping. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@el-mapache To your question, I would guess we go to 1.16.11
.
No description provided.