Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Update to 1.16.10 #1212

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Update to 1.16.10 #1212

merged 1 commit into from
Aug 29, 2017

Conversation

jcscottiii
Copy link
Contributor

No description provided.

Copy link
Contributor

@el-mapache el-mapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question!

@@ -1,6 +1,6 @@
{
"name": "cloudgov-dashboard",
"version": "1.16.9",
"version": "1.16.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, at what point do we roll this over to the next minor version? Do we stop at 10 or do we just stop when we feel like we've added a more significant piece of functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll bump it next major feature for the dashboard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what about the next minor version? For example, when does it become 1.17.0 vs 1.16.11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the next major feature will go to 1.17.0. Right now since we're doing mostly bug fixes, that's why i'm only bumping the patch number.
More about it here: https://github.com/18F/cg-dashboard/blob/adae679b1a7bb0611e2e02f5851cdfd9f786b350/RELEASE.md#updating-version-number

(Also, I think we may have messed up because we should've bumped minor when we did the user invite flow a few PIs ago)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I guess my question and/or example weren't clear. I was asking about minor, not major versions. But it seems like it's entirely up to the person doing the version bumping. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@el-mapache To your question, I would guess we go to 1.16.11.

@jcscottiii jcscottiii merged commit b1db0ec into master Aug 29, 2017
@jcscottiii jcscottiii deleted the release-1.16.10 branch August 29, 2017 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants