This repository has been archived by the owner on May 19, 2020. It is now read-only.
you need to get the spaces first on the org page #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-mapache
reviewed
Aug 9, 2017
static_src/routes.js
Outdated
| spaceActions.fetchAll().then(() => { | ||
| orgActions.toggleSpaceMenu(orgGuid); | ||
| orgActions.fetch(orgGuid); | ||
| cfApi.fetchSpaces().then(() => spaceActions.fetchAllForOrg(orgGuid)); |
There was a problem hiding this comment.
Does this mean we are fetching spaces two extra times per request?
There was a problem hiding this comment.
good catch! we shouldn't. updating
jcscottiii
force-pushed
the
js-fix-refresh-cases
branch
from
9a1f942 to
8e7ebe9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this case only happens when you refresh. before this PR, if you refreshed the org page, nothing would show. this PR fixes that by enforcing that the spaces be loaded. you have to load them first sequentially before the rest of the promises in case it doesn't finish first.